Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
| help="Fail if a testcase references an unknown requirement ID", | ||
| ) | ||
| parser.add_argument( | ||
| "--json-output", |
There was a problem hiding this comment.
It generates a summary of the result as json. The parameter is just to change the path
There was a problem hiding this comment.
Sure, but what for? I see two use cases:
- Generate an overview in the documentation.
- CI quality gate.
Neither of them uses this json file.
If there is some use for it, then there should be a Bazel rule/target to consume it. However, it looks like this code should rather be removed because nobody needs it.
| ) | ||
| ) | ||
| parser.add_argument( | ||
| "--needs-json", |
There was a problem hiding this comment.
I think this should simply be mandatory and there is no need to "search" for needs.json.
There was a problem hiding this comment.
Thats just if the path differs to increase flexibility
There was a problem hiding this comment.
I don't think it is a good idea to guess Bazel paths. Make it mandatory and explicit to loosen coupling between Script and Bazel.
AlexanderLanin
left a comment
There was a problem hiding this comment.
see discussion in #485
|
closed #485 @AlexanderLanin can you please check again? |
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
Some comments for things I noticed.
Will take another look after lunch.
Overall looks like genuine good work that we can build upon.
|
Also a general thing. If there is any 'substantial' or partial generation from AI please add the disclaimer in the header. Model name meaning like 'Gpt' or 'Copilot' or 'Claude' etc. |
I will add. But we should think about using tools like https://github.com/git-ai-project/git-ai in general |
Probably might be worth a look to see if we could use that. I can bring it up in infra. |
|
@FScholPer I would propose that I can take these Ideas & Proposals that you have made in this PR and re-implement them into Docs-As-Code so they fit a better architecturally and makes sense with how testcases etc. actually behave & are created inside the DaC frameworks that deal with it. I fear it would be a lot more work to merge this PR and then rebuild it / change it quiet heavily later when we want to integrate it. Do you think this would make sense and is a good way to move forward with this issue? @AlexanderLanin @a-zw please also advice here in your opinion what would be a good approach. |
|
to me it sounds like we need to discuss the goals first, then how to achieve it. Thats the reason why this mixes extensions with custom executables and no-one really understands why and how it should look like. |
Co-authored-by: Maximilian Sören Pollak <maximilian.pollak@qorix.com> Signed-off-by: Frank Scholter Peres(MBTI) <145544737+FScholPer@users.noreply.github.com>
Co-authored-by: Andreas Zwinkau <95761648+a-zw@users.noreply.github.com> Signed-off-by: Frank Scholter Peres(MBTI) <145544737+FScholPer@users.noreply.github.com>
4585a27 to
a364257
Compare
Goals for where 1. check linking of requirements to code/tests in ci 2. add dashboards in all modules. Or what goals do you have in mind? |
|
@FScholPer we've discussed this PR, unfortunately we missed you. So here is our interpretation. Let's have a call next week. The goals here are:
Here is an idea, which simplifies the design: What do you think? (May be not self explanatory) |

-> see eclipse-score/score#2774
Frank Scholter Peres frank.scholter_peres@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH
Provider Information